Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Cargo.lock #2

Closed
wants to merge 6 commits into from
Closed

Commit Cargo.lock #2

wants to merge 6 commits into from

Conversation

tennox
Copy link

@tennox tennox commented Jun 4, 2023

This is recommended for binaries (as opposed to libraries)
-> see https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

Also, I want to submit this to nixpkgs, and for that it's basically required 😋

This is recommended for binaries (as opposed to libraries)
-> see https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
@tennox
Copy link
Author

tennox commented Jun 4, 2023

I have the nixpkgs PR ready: NixOS/nixpkgs@master...tennox:nixpkgs:task-keeper
but I would only submit it after this is merged, for simplicity.

I also did not manage to get all the dependencies set up which would be needed for the tests to succeed 😞 - so I disabled tests when building the nix package for now. (fair enough)

@tennox
Copy link
Author

tennox commented Jun 9, 2023

I have submitted the nixpkgs PR in a way that works without this:
NixOS/nixpkgs#236516
but I'd still recommend that & like if this gets merged :)

@tennox tennox mentioned this pull request Nov 24, 2023
@tennox
Copy link
Author

tennox commented Nov 24, 2023

Closed in favor of a clean PR:
#5

@tennox tennox closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant