-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Increase retry limit in metadata fetch #1241
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please commit message to better reflect which metadata limit and where?
Let’s update the commit title as well. Could you also add more details to the PR, such as the number of iterations you ran to confirm the fix? |
Is this supposed to help with |
e3b1cad
to
7be0006
Compare
Probably should revert the whole file to what it was before my commit, not just the DataProvider part. Unless you intend to test the contribution of each change individually? I think bumping the RF from 1 to 2 may have been significant. The restructuring of setup/close code into Before/AfterMethod, IDK how much it actually helped, maybe it did, maybe not. |
Yes, was going to change the RF 1 next. setup/close I am not sure worth a try. |
##[server] Adjust retry limit in metadata fetch
Increase retry limit in for non-blocking metadata fetch method inside
getTopicPartitionEndOffSet
from 5 retries to 10 as too few retries made some tests fails.How was this PR tested?
Does this PR introduce any user-facing changes?