Merge pull request #319 from Poor12/improve-controller

fix: do not need reconcile when member cluster do not have mcs api
kubewharf · Mar 27, 2024 · 733e4a6 · 733e4a6
2 parents 73ab25f + d57ab81
commit 733e4a6
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/controllers/mcs/service_export_controller.go b/pkg/controllers/mcs/service_export_controller.go
@@ -461,8 +461,11 @@ func (c *ServiceExportController) filterEndpointSlice(
 
 	svcName := eps.Labels[discoveryv1b1.LabelServiceName]
 	seListerInterface, synced, exists := c.fedInformerManager.GetResourceListerFromFactory(common.ServiceExportGVR, key.cluster)
-	if !exists || !synced() {
-		return true, fmt.Errorf("informer of serviceExport not exists or not synced for cluster %s", key.cluster)
+	if !exists {
+		return false, nil
+	}
+	if !synced() {
+		return true, fmt.Errorf("informer of serviceExport not synced for cluster %s", key.cluster)
 	}
 
 	seLister, ok := seListerInterface.(cache.GenericLister)