kcc support priority and its allowed selector key list configurations #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynepeking348
previously approved these changes
Aug 4, 2023
luomingmeng
force-pushed
the
dev/kcc_support_priority_and_selector_key_list
branch
2 times, most recently
from
cce97b8
to
588be3f
Compare
waynepeking348
previously approved these changes
Aug 8, 2023
luomingmeng
force-pushed
the
dev/kcc_support_priority_and_selector_key_list
branch
from
588be3f
to
0716dab
Compare
csfldf
approved these changes
Aug 8, 2023
waynepeking348
approved these changes
Aug 8, 2023
caohe
approved these changes
Aug 8, 2023
luomingmeng
added
workflow/merge-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
To enhance the functionality of KCC (Katalyst Custom Configuration), it is necessary to extend its support for multiple node selector keys instead of just one. This is required because in certain scenarios, the node configuration may be differentiated by multiple labels, such as machine type, sub-cluster, physical space, and other attributes.
By allowing the involvement of multiple keys in the selector, there is a higher likelihood of configuration overlap. To address this, we propose introducing a priority system that enables the overriding of lower priority configurations in specific cases, such as during degradation.