chore(backend): remove usage of deprecated commonLabels in Kustomize manifests #11289
Conversation
Signed-off-by: etheleon <[email protected]>
|
Hi @etheleon. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
resolves #11272 |
etheleon
force-pushed
the
update-manifests-issue-11272
branch
6 times, most recently
from
cd2da5e
to
2ac97d1
Compare
Used `kustomize edit fix --vars` Signed-off-by: etheleon <[email protected]>
etheleon
force-pushed
the
update-manifests-issue-11272
branch
from
2ac97d1
to
2b40df0
Compare
|
running |
|
/verify-owners |
|
/ok-to-test |
|
@HumairAK could you approve the workflow runs? ty! |
manifests/kustomize/base/installs/generic/postgres/postgres-secret-extended.yaml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
ci-passed
Signed-off-by: etheleon <[email protected]>
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
| # Identifier for application manager to apply ownerReference. | ||
| # The ownerReference ensures the resources get garbage collected | ||
| # when application is deleted. |
There was a problem hiding this comment.
This comment got misplaced.
Description of your changes:
Removed commonLabels since it's deprecated in Kustomize's api/v0.16.0 release. In it's place labels and selectors should be mentioned explicitly in the resource.
Checklist: