Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add strategy and max_wait_duration to v1 GCPC custom job components/utils #11286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

copybara-service[bot]
Copy link
Contributor

feat(components): add strategy and max_wait_duration to v1 GCPC custom job components/utils

Signed-off-by: Ze Mao [email protected]

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ironpan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @copybara-service[bot]. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@copybara-service copybara-service bot force-pushed the test_684613251 branch 5 times, most recently from a6c8e28 to 03095f1 Compare October 14, 2024 19:16
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 14, 2024
@github-actions github-actions bot removed the ci-passed All CI tests on a pull request have passed label Oct 14, 2024
…m job components/utils

Signed-off-by: Ze Mao <[email protected]>
PiperOrigin-RevId: 684613251
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed All CI tests on a pull request have passed needs-ok-to-test size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants