-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the old tekton version #2772
base: master
Are you sure you want to change the base?
Remove the old tekton version #2772
Conversation
@rimolive can you review this, because you are actively working on the tekton merge? |
@rimolive do you have any concerns? |
My advice is to not remove yet. I don't think we had the kfp manifests prepared to use argo or tekton as backend, and these manifests are the reference. Let's see who will continue the kfp-tekton merge work and let them know this manifest work is missing. |
alright then lets close for now and focus on something else. |
@rimolive either we get a new kfp-tekton release (https://github.com/kubeflow/manifests/blob/2269c67372dd4664edf5faae9eb80d90db2ae7d0/hack/sync-kfp-tekton-manifests.sh) or we have to remove the separate 2.0.5 kfptekton from the manifests since it add many CVEs and seems to be abandoned. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also #2856 @hansinikarunarathne please rebase or create a new PR for this. |
Even in this excerpt the differences are massive
|
Is there relationship between CVE count and tekton ? can you elaborate on this more ? |
…ekton/upstream folder and https://github.com/kubeflow/manifests/blob/master/.github/issue_label_bot.yaml file Signed-off-by: hansinikarunarathne <[email protected]>
ad32e0f
to
6c8ea77
Compare
I rebased the PR with master |
/lgtm @rimolive is there any plan to revive the tekton repository for 1.10? |
@animeshsingh Are you still maintaining and planning to update https://github.com/kubeflow/kfp-tekton for KFP 2.2.0+? The last commit is soon 6 months old and it adds a massive amount of CVEs. |
Please check the main readme and /hack folder for tekton related things. |
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
🐛 If this PR is related to an issue, please put the link of the issue here.
✅ Contributor checklist
DCO
check)cla/google
check)