Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera page layout improvements + More prominent and rewritten disclaimer #33

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

sgwilym
Copy link
Contributor

@sgwilym sgwilym commented Mar 20, 2018

In an attempt to help address #32:

pp-layout

  • This PR simplifies the camera page's layout using flexbox, as there would be problems with the Dynamicland disclaimer text overflowing and being obscured behind the camera view at certain window sizes. This should also make the layout more accommodating for future changes.
  • I've taken the liberty of rewriting the Dynamicland disclaimer message -- I felt like the last one didn't do a very good job of clarifying that Paper Programs doesn't have the same depth as Dynamicland, but maybe I've taken something out that others felt was equally important.

Sorry that the diff is a little hard to make sense of -- I've really only wrapped some existing elements in new parents and edited the CSS.

Alter disclaimer to be more visually prominent
Rewrite disclaimer message to emphasise thin-sliciness
Copy link
Owner

@janpaul123 janpaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 💯 This was easy to review with the ?w=1 URL trick. 😄 And the message you wrote is great!!

@janpaul123 janpaul123 merged commit decf886 into janpaul123:master Mar 21, 2018
@sgwilym sgwilym deleted the disclaimer-layout-message branch March 21, 2018 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants