ErrorHandler#harshly no longer fails when backtrace nil #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estraph
force-pushed
the
raph/harshly
branch
2 times, most recently
from
ddd2424
to
a1e7cc7
Compare
|
Based on The safe navigation operator was only added in Ruby 2.3, so we can't use it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception doesn't have a
backtrace(it isnil), theharshlymethod can blow up, masking the underlying exception with this instead:This PR updates the call to
jointo use the safe navigation operator which will result in the backtrace in the message being empty, and allowingharshlyto re-raise the original exception as intended.