Option/Settings refactoring, logging improvements, raw setting editing, Firefox support #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchcapper
force-pushed
the
various_improvements
branch
from
ca760e0
to
f763fdd
Compare
|
Rebased onto master also added firefox support. If merged into master make sure to update the manifest with your own id. |
we will need to do more work to support those that don't have window.chrome
mitchcapper
force-pushed
the
various_improvements
branch
from
f763fdd
to
84ce29e
Compare
Filling the left out part in the last CSS update
Adjusting the HTML for the updated css
mitchcapper
changed the title
…ut the video element and url we are on
…thout page changes
Added option to fix YT speed pref where shadow element screws our speed changes
|
Fixed YT issues where your speed changes would get multiplied due to a shadow video element unless you had "forceLastSavedSpeed". That setting is now migrated to a new video speed event action enum to add the new "IgnoreWhenVideoZeroSized" which fixes the YT issue without ignoring all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has many changes, if any of them are wanted let me know and i can refactor into individual commits / PR's. Here is a list of the changes made:
https://github.com/mitchcapper/videospeed/blob/various_improvements/ourchanges.md
I wouldn't normally just do a blob PR like this but as many of the changes are interweaved it will take longer form me to separate them out and hope to avoid merge conflicts when combining for a feature-set that may not be desired.