Switch to {app}.{area}.{event} format for analytics events (#8643)

hypothesis · Apr 3, 2024 · a9c10c1 · a9c10c1
1 parent b9f99a0
commit a9c10c1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/h/schemas/analytics.py b/h/schemas/analytics.py
@@ -10,7 +10,7 @@ class EventSchema(JSONSchema):
         "properties": {
             "event": {
                 "type": "string",
-                "enum": ["APPLY_PENDING_UPDATES"],
+                "enum": ["client.realtime.apply_updates"],
             },
         },
     }

diff --git a/tests/unit/h/schemas/analytics_test.py b/tests/unit/h/schemas/analytics_test.py
@@ -12,7 +12,7 @@ class TestCreateEventSchema:
             ({"foo": "bar"}, "'event' is a required property"),
             (
                 {"event": "invalid"},
-                "event: 'invalid' is not one of \\['APPLY_PENDING_UPDATES'\\]",
+                "event: 'invalid' is not one of \\['client.realtime.apply_updates'\\]",
             ),
         ],
     )
@@ -23,6 +23,6 @@ def test_error_for_invalid_data(self, payload: dict, expected_error: str):
 
     def test_valid_data_is_returned(self):
         schema = CreateEventSchema()
-        result = schema.validate({"event": "APPLY_PENDING_UPDATES"})
+        result = schema.validate({"event": "client.realtime.apply_updates"})
 
-        assert result == {"event": "APPLY_PENDING_UPDATES"}
+        assert result == {"event": "client.realtime.apply_updates"}
diff --git a/tests/unit/h/views/api/analytics_test.py b/tests/unit/h/views/api/analytics_test.py
@@ -7,7 +7,7 @@
 @pytest.mark.usefixtures("analytics_service")
 class TestCreateEvent:
     def test_analytics_service_is_invoked(self, pyramid_request, analytics_service):
-        pyramid_request.json_body = {"event": "APPLY_PENDING_UPDATES"}
+        pyramid_request.json_body = {"event": "client.realtime.apply_updates"}
         res = create_event(pyramid_request)
 
         assert analytics_service.create.called