[Judges] use the pair-judges in online-preference trainers #2243
+148
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Oct 17, 2024
qgallouedec
reviewed
Oct 17, 2024
qgallouedec
reviewed
Oct 17, 2024
|
@kashif can you also add an example in the online dpo documentation? And a test? |
|
working on test thanks! |
Co-authored-by: Quentin Gallouédec <[email protected]>
Co-authored-by: Quentin Gallouédec <[email protected]>
qgallouedec
reviewed
Oct 17, 2024
Comment on lines
+427
to
+429
| self.processing_class.decode(ids[:context_length], skip_special_tokens=True) | ||
| for ids in prompt_completion_ids[:num_examples] | ||
| ] |
There was a problem hiding this comment.
can we use batch_decode here?
qgallouedec
reviewed
Oct 18, 2024
Comment on lines
+389
to
+398
| # self._log_statistics( | ||
| # model_data, | ||
| # mixture_data, | ||
| # model_logprobs_model_data.detach(), | ||
| # ref_logprobs_model_data, | ||
| # probability, | ||
| # score.detach(), | ||
| # kl_div.detach(), | ||
| # context_length, | ||
| # ) |
qgallouedec
reviewed
Oct 18, 2024
qgallouedec
reviewed
Oct 18, 2024
qgallouedec
reviewed
Oct 18, 2024
Co-authored-by: Quentin Gallouédec <[email protected]>
Co-authored-by: Quentin Gallouédec <[email protected]>
Co-authored-by: Quentin Gallouédec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add support for judges API in online-pref methods