-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minicpm enabling #1342
Open
pi314ever
wants to merge
10
commits into
huggingface:main
Choose a base branch
from
pi314ever:minicpm-enabling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Minicpm enabling #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance benchmark python run_generation.py --model_name_or_path openbmb/MiniCPM3-4B --max_new_tokens 512 --prompt "推荐5个北京的景点。" --batch_size 1 --temperature 0.7 --do_sample --top_p 0.7 --use_kv_cache --use_chat_template --use_hpu_graphs [--bf16]
|
pi314ever
requested review from
ssarkar2,
bhargaveede,
vivekgoe and
regisss
as code owners
September 20, 2024 21:23
pi314ever
force-pushed
the
minicpm-enabling
branch
from
September 25, 2024 00:24
b48031e
to
0a7133e
Compare
pi314ever
force-pushed
the
minicpm-enabling
branch
from
October 9, 2024 23:13
0a7133e
to
7092e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables MiniCPM3 model for Causal LM. Follows #1133 in optimizing remote code. The following changes were added:
htcore.mark_step()
between each decoder layer to reduce graph sizetoken_idx
support passthrough to Attention implementations. (Currently incomplete, missing reset of cache)Before submitting