Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: migrated bopis settings from user preference to product store settings, and added permission over them (#433) #436

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

amansinghbais
Copy link
Contributor

Related Issues

#433

Short Description and Why It's Useful

  • Migrated settings from user preference to the product store settings.
  • Added permisisons over the settings card.

PR for support to add permission over product identifier: hotwax/dxp-components#327

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

package.json Outdated
@@ -17,7 +17,7 @@
"@casl/ability": "^6.0.0",
"@hotwax/app-version-info": "^1.0.0",
"@hotwax/apps-theme": "^1.2.6",
"@hotwax/dxp-components": "^1.15.2",
"@hotwax/dxp-components": "file:../dxp-components",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct this.

@ravilodhi ravilodhi merged commit 1264b29 into hotwax:main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants