Implemented: support for print picklist in open orders (#415) #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icklists functionality (hotwax#415)
…king is not enabled (hotwax#415)
…n if picklist already created (hotwax#415)
ravilodhi
reviewed
Sep 11, 2024
src/views/Orders.vue
Outdated
| if(!hasError(resp)) { | ||
| showToast(translate("Order packed and ready for delivery")); | ||
| const orders = JSON.parse(JSON.stringify(this.orders)); | ||
| const orderIndex = orders.findIndex((order: any) => { |
There was a problem hiding this comment.
We have the similar code to remove updated order in two places. Can we have single action for this logic?
ravilodhi
reviewed
Sep 11, 2024
src/views/Orders.vue
Outdated
| } | ||
| }] | ||
| }); | ||
| return alert.present(); | ||
| }, | ||
| async packShippingOrders(currenOrder: any, part: any) { |
There was a problem hiding this comment.
Remove part, as it is not used.
ravilodhi
reviewed
Sep 11, 2024
| componentProps: { order, part, facilityId: this.currentFacility.facilityId } | ||
| }); | ||
|
|
||
| assignPickerModal.onDidDismiss().then(async(result: any) => { |
There was a problem hiding this comment.
This logic should be improved for better readability like, if configure picker is off then set the pickerPartyId to NA else open modal and then set the selected pickerPartyId. In the end if pickerPartyId is set then only run the ceratePicklist flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#415
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance