Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kevin Yu's profile to Civic Tech Job section of Projects Page #7598

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

srinipandiyan
Copy link
Member

@srinipandiyan srinipandiyan commented Oct 16, 2024

Fixes #7556

What changes did you make?

  • Added a profile card with Kevin Yu's data to the Civic Tech Jobs section of the Projects page.
  • Updated civic-tech-jobs.md file to include Kevin Yu's profile info:
- name: Kevin Yu
  github-handle: kevin31yu
  role: Developer
  links:
    slack: https://hackforla.slack.com/team/U061GQQ56Q4
    github: https://github.com/kevin31yu
  picture: https://avatars.githubusercontent.com/kevin31yu

Why did you make the changes (we will use this info to test)?

  • To update the fronted interface for end-clients to reflect the latest profile data within the Civic Tech Jobs section.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Before Kevin Yu's Profile Card
Visuals after changes are applied After Kevin Yu's Profile Card

@srinipandiyan srinipandiyan added good first issue Good for newcomers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 16, 2024
@siyunfeng siyunfeng self-requested a review October 16, 2024 20:47
@siyunfeng
Copy link
Member

Review ETA: 8 PM 10/16/24 (EDT)
Availability: 6-10 PM Weekdays (EDT)

@siyunfeng
Copy link
Member

Hi, @srinipandiyan !

I appreciate the clear details in What changes did you make? to clarify the corresponding changes to this issue. You also did a good job providing your availability and ETA in the original issue.

I'm not able to pull the date from your branch due to the branch conflicts. You might forget to pull/sync from the gh-pages branch before making the changes or submitting your PR. I recommend you resolve the conflicts so I will be able to review the changes you made.

Branch conflicts:

7556-pull-conflict

@srinipandiyan
Copy link
Member Author

Hi @siyunfeng,

I've synced the PR. Please try again at your convenience. Thank you!

Best,

Srini

@codyyjxn codyyjxn self-requested a review October 17, 2024 02:30
@codyyjxn
Copy link
Member

Review ETA: EOD
Availability: M > F

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @srinipandiyan !

The changes you made are applicable to the issue. The before-and-after screenshots you provided are helpful to show the changes.

Improvements:

  • Run git pull from gh-pages before working on the issue and submitting the PR to prevent branch conflicts in the future
  • Update the before-and-after screenshots after updating your PR if the view changed
  • Name the branch with more specific details, such as add-kevin-yu-to-civic-tech-job-7556

Thank you for your contribution!

@srinipandiyan srinipandiyan requested review from pluto-bell and innith and removed request for codyyjxn October 18, 2024 02:12
@codyyjxn codyyjxn self-requested a review October 18, 2024 02:51
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @srinipandiyan great job on taking on this issue.
The issue is linked correctly and the branch name is clear. Thank you for also providing the screenshots which help anyone see what changes were made.
Great Job! Keep it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Status: PRs ✅ waiting for merge team
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Add Kevin Yu
3 participants