Mattermost Alert Flow #5173
Open
Mattermost Alert Flow #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravishankar15
force-pushed
the
mattermost-alert-flow
branch
from
2e251ae
to
4b4b468
Compare
Add message type column Fix minor changes
ravishankar15
force-pushed
the
mattermost-alert-flow
branch
from
4b4b468
to
fe407db
Compare
| if self.alert_group.acknowledged: | ||
| actions.append(_make_actions("unacknowledge", "Unacknowledge", token)) | ||
| else: | ||
| actions.append(_make_actions("acknowledge", "Acknonwledge", token)) |
There was a problem hiding this comment.
typo: Acknonwledge -> Acknowledge
Also visible in your screenshot :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR closes
Mattermost message screenshot,
Related to [issue link here]
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.