set default grafana_url if GRAFANA_API_URL set #4702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Oncall backend calling grafana api when grafana is self hosted and under certain path
fixes errors like:
while GRAFANA_API_URL=https://test.com/grafana
relevant for when external self-hosted grafana has same URL, but under different path, like /grafana
Also fixes issue when self.api_url has path, but no '/' in the end
because in case of
urljoin(self.api_url, endpoint)
Example:
https://test.com/path
,api/v1
-> will becomehttps://test.com/api/v1
https://test.com/path/
,api/v1
-> will becomehttps://test.com/path/api/v1