Skip to content

Commit

Permalink
Merge pull request #2326 from Demonsthere/feat/tempo-memberlist-config
Browse files Browse the repository at this point in the history
[tempo-distributed] feat: add memberlist values
  • Loading branch information
zanhsieh authored Jul 23, 2023
2 parents f3e5c7e + 9e30bdf commit a0d1d53
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/tempo-distributed/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-distributed
description: Grafana Tempo in MicroService mode
type: application
version: 1.4.12
version: 1.4.13
appVersion: 2.1.1
engine: gotpl
home: https://grafana.com/docs/tempo/latest/
Expand Down
3 changes: 2 additions & 1 deletion charts/tempo-distributed/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# tempo-distributed

![Version: 1.4.12](https://img.shields.io/badge/Version-1.4.12-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.1.1](https://img.shields.io/badge/AppVersion-2.1.1-informational?style=flat-square)
![Version: 1.4.13](https://img.shields.io/badge/Version-1.4.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.1.1](https://img.shields.io/badge/AppVersion-2.1.1-informational?style=flat-square)

Grafana Tempo in MicroService mode

Expand Down Expand Up @@ -480,6 +480,7 @@ The memcached default args are removed and should be provided manually. The sett
| license.contents | string | `"NOTAVALIDLICENSE"` | |
| license.external | bool | `false` | |
| license.secretName | string | `"{{ include \"tempo.resourceName\" (dict \"ctx\" . \"component\" \"license\") }}"` | |
| memberlist | object | `{"abort_if_cluster_join_fails":false,"bind_addr":[],"bind_port":7946,"gossip_interval":"1s","gossip_nodes":2,"gossip_to_dead_nodes_time":"30s","leave_timeout":"5s","left_ingesters_timeout":"5m","max_join_backoff":"1m","max_join_retries":10,"min_join_backoff":"1s","node_name":"","packet_dial_timeout":"5s","packet_write_timeout":"5s","pull_push_interval":"30s","randomize_node_name":true,"rejoin_interval":"0s","retransmit_factor":2,"stream_timeout":"10s"}` | Memberlist configuration. Please refer to https://grafana.com/docs/tempo/latest/configuration/#memberlist |
| memcached.affinity | string | Hard node and soft zone anti-affinity | Affinity for memcached pods. Passed through `tpl` and, thus, to be configured as string |
| memcached.enabled | bool | `true` | Specified whether the memcached cachce should be enabled |
| memcached.extraArgs | list | `[]` | Additional CLI args for memcached |
Expand Down
26 changes: 25 additions & 1 deletion charts/tempo-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,28 @@ traces:
# -- Enable Tempo to ingest traces from Kafka. Reference: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/kafkareceiver
kafka: {}

# -- Memberlist configuration. Please refer to https://grafana.com/docs/tempo/latest/configuration/#memberlist
memberlist:
node_name: ""
randomize_node_name: true
stream_timeout: "10s"
retransmit_factor: 2
pull_push_interval: "30s"
gossip_interval: "1s"
gossip_nodes: 2
gossip_to_dead_nodes_time: "30s"
min_join_backoff: "1s"
max_join_backoff: "1m"
max_join_retries: 10
abort_if_cluster_join_fails: false
rejoin_interval: "0s"
left_ingesters_timeout: "5m"
leave_timeout: "5s"
bind_addr: []
bind_port: 7946
packet_dial_timeout: "5s"
packet_write_timeout: "5s"

# -- Config file contents for Tempo distributed. Passed through the `tpl` function to allow templating

# @default -- See values.yaml
Expand Down Expand Up @@ -1144,7 +1166,9 @@ config: |
complete_block_timeout: {{ .Values.ingester.config.complete_block_timeout }}
{{- end }}
memberlist:
abort_if_cluster_join_fails: false
{{- with .Values.memberlist }}
{{- toYaml . | nindent 2 }}
{{- end }}
join_members:
- {{ include "tempo.fullname" . }}-gossip-ring
overrides:
Expand Down

0 comments on commit a0d1d53

Please sign in to comment.