feat(openai): handle error messages in chat completion streams #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
added a commit
to grafana/grafana-llmexamples-app
that referenced
this pull request
Sep 27, 2023
Demonstrates how to use grafana/grafana-experimental#86 to handle errors occurring in a stream.
sd2k
added a commit
to grafana/grafana-llmexamples-app
that referenced
this pull request
Sep 27, 2023
Demonstrates how to use grafana/grafana-experimental#86 to handle errors occurring in a stream.
Once grafana/grafana-llm-app#75 is merged we'll need to be able to handle error messages in the streams returned by `streamChatCompletions`. This commit intercepts those errors and re-throws them inside the Observable, so they can be handled using the `error` property of `stream.subscribe`.
sd2k
force-pushed
the
handle-errors-in-streams
branch
from
642a42d
to
0ca4492
Compare
sd2k
added a commit
to grafana/grafana-llmexamples-app
that referenced
this pull request
Sep 27, 2023
Demonstrates how to use grafana/grafana-experimental#86 to handle errors occurring in a stream.
sd2k
added a commit
to grafana/grafana-llmexamples-app
that referenced
this pull request
Sep 27, 2023
Demonstrates how to use grafana/grafana-experimental#86 to handle errors occurring in a stream.
SandersAaronD
approved these changes
Sep 27, 2023
|
I don't really like the use of |
sd2k
added a commit
that referenced
this pull request
Sep 27, 2023
SandersAaronD
pushed a commit
to grafana/grafana-llm-app
that referenced
this pull request
Oct 27, 2023
SandersAaronD
pushed a commit
to grafana/grafana-llm-app
that referenced
this pull request
Oct 30, 2023
SandersAaronD
pushed a commit
to grafana/grafana-llm-app
that referenced
this pull request
Oct 31, 2023
SandersAaronD
pushed a commit
that referenced
this pull request
Jan 10, 2024
feat(openai): handle error messages in chat completion streams
SandersAaronD
pushed a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once grafana/grafana-llm-app#75 is merged we'll need to be able to handle error messages in the streams returned by
streamChatCompletions. This commit updates the types on the response stream and adds a newhandleErroroperator which users can provide with a callback to handle an error if one occurs.