-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct type check for the onBlur handler for SQLEditor #116
Conversation
hi @shelldandy , could you please explain the use-case where you need this? i mean, |
For some reason on the VariableQueryEditor page the Run Query button on the page sometimes it's not on sync with the rest of the page (probably because on earlier grafana versions that button wasn't there) So to fix that issue what we've been doing on enterprise Datasources is to add an onBlur event to force a model update of the onChange function so hitting the button works as intended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to bump the version and changelog
…qleditor-type-fix
Otherwise type checking fails when attempting to use the prop as intended:
https://github.com/grafana/grafana-experimental/blob/main/src/sql-editor/components/SQLEditor.tsx#L115-L118