OperationEditor: Fix rendering of operation editor items #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
matyax,
svennergr and
gtk-grafana
and removed request for
svennergr
matyax
reviewed
Jan 30, 2024
matyax
reviewed
Jan 30, 2024
Comment on lines
+35
to
+52
| const onParamValueChanged = (paramIdx: number, value: QueryBuilderOperationParamValue) => { | ||
| const update: QueryBuilderOperation = { ...operation, params: [...operation.params] }; | ||
| update.params[paramIdx] = value; | ||
| callParamChangedThenOnChange(definition, update, index, paramIdx, onChange); | ||
| }; | ||
|
|
||
| const onAddRestParam = () => { | ||
| const update: QueryBuilderOperation = { ...operation, params: [...operation.params, ''] }; | ||
| callParamChangedThenOnChange(definition, update, index, operation.params.length, onChange); | ||
| }; | ||
|
|
||
| const onRemoveRestParam = (paramIdx: number) => { | ||
| const update: QueryBuilderOperation = { | ||
| ...operation, | ||
| params: [...operation.params.slice(0, paramIdx), ...operation.params.slice(paramIdx + 1)], | ||
| }; | ||
| callParamChangedThenOnChange(definition, update, index, paramIdx, onChange); | ||
| }; |
There was a problem hiding this comment.
I would conside useCallback these, now that we're at it, as it doesn't need to change the children on every render.
matyax
reviewed
Jan 30, 2024
Comment on lines
+55
to
+61
| let restParam: React.ReactNode | undefined; | ||
| if (definition.params.length > 0) { | ||
| const lastParamDef = definition.params[definition.params.length - 1]; | ||
| if (lastParamDef.restParam) { | ||
| restParam = renderAddRestParamButton(lastParamDef, onAddRestParam, index, operation.params.length, styles); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced an issue when I was refactoring OperationEditor (at that time in
grafana/grafana, but because I wasn't passing props correctly to component, it was doing a lot of mounting - unmounting grafana/grafana@7be8301. I will have to do this fix also ingrafana/grafanaThis PR takes previously called
StyledOperationHeaderand moves it to separate file and makes it a proper component that doesn't cause -remounting of each operation editor.Fixed:
fixed.mov
Broken:
broken.mov
How to test:
yarn linkand test this locally, do that.package.jsontocustomgrafana/grafanapackage.jsonadd"custom": "file: ../grafana-experimental"OperationListin Loki fromcustom