Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added partial codeowners file #100

Merged
merged 1 commit into from
Jan 16, 2024
Merged

added partial codeowners file #100

merged 1 commit into from
Jan 16, 2024

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Jan 15, 2024

the oss-big-tent squad is fine with owning the sql-related code in this repo, so i made a CODEOWNERS that reflects this. of course, if someone else wants to own it too, feel free to comment and we can modify this👍 .

(NOTE: github is complaining that the codeowners is not valid because oss-big-tent has no write access, i'll solve that if/when this gets approved)

@gabor
Copy link
Contributor Author

gabor commented Jan 15, 2024

(i just picked the last 5 committers as reviewers 😄 )

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me! 🙂

Copy link
Contributor

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tolzhabayev
Copy link

tolzhabayev commented Jan 15, 2024

Screenshot 2024-01-15 at 13 15 12

you should add the @grafana/oss-big-tent team as writers to this repository.

Update: just saw your message in the description, ignore me :)

@gabor gabor merged commit f7e0d66 into main Jan 16, 2024
2 checks passed
@gabor gabor deleted the gabor/codeowners branch January 16, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants