Emit internal error metrics #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be changed to use
statsdat some point, since ourgo-expvarmetrics don't support tagging, which is why we need to emit metrics in this format.Difference between
check.any.errorand the newly introducedcheck.any.internal-erroris thatcheck.any.errorcounts anything that is a status code 200 as an error. This includes all rate limiting events.Tracking
check.any.internal-errorwill make it possible for us to track actual errors that are caused byfrenonot being able to connect to mysql, or freno failing in any other way.