Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that data_column parameters have a valid data_ref #18949

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

  • data_ref needs to be specified in the XML
  • data_ref needs to refer to an existing parameter

Fixes #18359 (i.e. the misleading error message, since now the KeyError caused by missing/wrong data_ref are replaced by AssertionErrors which will be reported properly, but still as tool loading error)

Questions:

  • Do we need a profile version for this?
  • I could add linter rule(s) for this, but I guess this should be done in a larger project analogous to this, which should cover all allowed/required attribute combinations for <param>?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

- it needs to be specified in the XML
- needs to refer to an existing parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS Error when creating new repo
1 participant