Be specific about the platforms the role supports #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think claiming that it works with all versions of EL and Ubuntu is naive, let's be specific.
|
I don't think it's naïve, it's a bash script that's downloaded, there is absolutely nothing platform specific in here, no platform specific nor version specific package names (e.g. databases). |
Yes, I also think it is unlikely that things will fail, I was just trying to be consistent with the tested versions. If something ever fails we can always come back to this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think claiming that it works with all versions of EL and Ubuntu is naive, let's be specific.
The motivation for this PR is #10.