feat: Allow for changing cached reads inside of BlockBuildingHelperFromDB #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7suyash7 <[email protected]>
ZanCorDX
reviewed
Sep 25, 2024
Comment on lines
262
to
266
|
|
||
| /// Updates the cached reads for the block state. | ||
| pub fn update_cached_reads(&mut self, cached_reads: CachedReads) { | ||
| self.block_state = self.block_state.clone().with_cached_reads(cached_reads); | ||
| } |
There was a problem hiding this comment.
Why is this here as a pub function and not implemented directly on impl BlockBuildingHelper for BlockBuildingHelperFromDB?
There was a problem hiding this comment.
Sorry, my bad, just fixed it.
Signed-off-by: 7suyash7 <[email protected]>
Benchmark results for
|
| Date (UTC) | 2024-09-27T13:39:32+00:00 |
| Commit | 0468692b67e65e8822d3203e0051837b516e24ce |
| Base SHA | 73629a2face0eeb18c0c5c6c5a79a62f25da7729 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| MEV-Boost SubmitBlock serialization/JSON encoding | -37.20% | Performance has improved. |
ZanCorDX
approved these changes
Sep 27, 2024
astarinmymind
pushed a commit
that referenced
this pull request
Oct 3, 2024
…omDB (#189) - Added `update_cached_reads` method to the `BlockBuildingHelper` trait - Implemented `update_cached_reads` for `BlockBuildingHelperFromDB` - Updated `MockBlockBuildingHelper` to include an unimplemented `update_cached_reads` method * [ ✅] Run `make lint` * [✅ ] Run `make test` --------- Signed-off-by: 7suyash7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#178
update_cached_readsmethod to theBlockBuildingHelpertraitupdate_cached_readsforBlockBuildingHelperFromDBMockBlockBuildingHelperto include an unimplementedupdate_cached_readsmethod✅ I have completed the following steps:
make lintmake test