Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BlockBuildingHelperFromDB allows for changing cached reads #178

Open
bertmiller opened this issue Sep 14, 2024 · 0 comments
Open

feat: BlockBuildingHelperFromDB allows for changing cached reads #178

bertmiller opened this issue Sep 14, 2024 · 0 comments

Comments

@bertmiller
Copy link
Member

It would be useful for some block building algorithms to be able to add/change the cached reads on the block state within BlockBuildingHelperFromDB. This change should be simple, just expose a function that takes CachedReads as an input and calls .with_cached_reads on block_state.
@7suyash7 7suyash7 mentioned this issue Sep 24, 2024
Merged
ZanCorDX pushed a commit that referenced this issue Sep 27, 2024
@7suyash7
feat: Allow for changing cached reads inside of BlockBuildingHelperFr…
10495ea 
…omDB (#189)

#178 

- Added `update_cached_reads` method to the `BlockBuildingHelper` trait
- Implemented `update_cached_reads` for `BlockBuildingHelperFromDB`
- Updated `MockBlockBuildingHelper` to include an unimplemented
`update_cached_reads` method

## ✅ I have completed the following steps:

* [ ✅] Run `make lint`
* [✅ ] Run `make test`

---------

Signed-off-by: 7suyash7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bertmiller