Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy setup improvements #356

Merged
merged 2 commits into from
Sep 24, 2024
Merged

mypy setup improvements #356

merged 2 commits into from
Sep 24, 2024

Conversation

jernst
Copy link
Member

@jernst jernst commented Sep 24, 2024

Make mypy invocation from inside pre-commit and standalone more consistent. Partial success only.

Johannes Ernst added 2 commits September 24, 2024 10:49
…g.yaml and add more surgical disable comment into the source

Make Makefile-invoked mypy options consistent with those in .pre-commit-config.yaml
Put --ignore-missing-imports back into .pre-commit-config; lots of errors without although this flag is not needed when mypy is invoked outside of pre-commit
Copy link
Member

@steve-bate steve-bate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used it much but typing.TYPE_CHECKING might be useful to conditionally define Mastodon et al during type checking (since the node loader won't be changing the import behavior at that time).

@jernst jernst merged commit 5995135 into fediverse-devnet:develop Sep 24, 2024
1 check passed
@jernst jernst deleted the pr-mypy branch September 24, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants