Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flop counter for mul operation #120

Closed
wants to merge 2 commits into from
Closed

add flop counter for mul operation #120

wants to merge 2 commits into from

Conversation

jixiege
Copy link

@jixiege jixiege commented Nov 17, 2022

Summary: add flop counter for elementwise product between tensors.

Though there is an implementation using elementwise_flop_counter(1) in #99, but it does not support broadcasting to a common shape.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2022
@ppwwyyxx
Copy link
Contributor

Just use elementwise_flop_counter(0, 1). It supports broadcasting.

@jixiege
Copy link
Author

jixiege commented Nov 19, 2022

Just use elementwise_flop_counter(0, 1). It supports broadcasting.

That's right, should be elementwise_flop_counter(0, 1) instead of elementwise_flop_counter(1).

Thanks for your correct.

@jixiege jixiege changed the title add flop counter for mul operation supporting broadcast add flop counter for mul operation Nov 19, 2022
@jixiege jixiege closed this Dec 1, 2022
@jixiege jixiege deleted the dev branch December 1, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants