Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update generator function documentation #398

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ferdeleong
Copy link

Update the return type documentation on all generator functions from np.ndarray to torch.Tensor. Additionally, document cases where the returned tensor shape may change.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
Copy link
Contributor

@JasonKChow JasonKChow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work with additional details on description.

Please add the relevant type hints as directed by comments. Double check if other generator methods are missing the Tensor return type hints where relevant.

@@ -57,7 +57,7 @@ def gen(
Args:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint for return

@@ -80,7 +80,7 @@ def gen(
num_points (int, optional): Number of points to query.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add type hint for return

@@ -55,7 +55,8 @@ def gen(
Args:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type hint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants