Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threat logger module rename #315

Merged
merged 2 commits into from
Sep 26, 2024
Merged

threat logger module rename #315

merged 2 commits into from
Sep 26, 2024

Conversation

banditopazzo
Copy link
Member

Fixes #310 renaming logger to threat-logger in a consistent way

@banditopazzo banditopazzo self-assigned this Sep 19, 2024
@banditopazzo banditopazzo added the bug Something isn't working label Sep 19, 2024
vadorovsky
vadorovsky requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also one other place which needs the rename:

pulsar/crates/modules/README.md

Line 8 in 741c619

| `logger` | Consumer | Log events to stdout. Used for development and toubleshooting

crates/modules/threat-logger/README.md Show resolved Hide resolved
@vadorovsky vadorovsky merged commit e0645e6 into main Sep 26, 2024
21 checks passed
@vadorovsky vadorovsky deleted the 310_fix_threat_logger_rename branch September 26, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees

@banditopazzo banditopazzo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logger module ignores the config
2 participants
@banditopazzo @vadorovsky