Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parquet building logs + profiling to evidence * commands #2654

Open
wants to merge 8 commits into
base: next
Choose a base branch
from

Conversation

csjh
Copy link
Contributor

@csjh csjh commented Oct 16, 2024

Description

Adds logging to build-parquet.js (mainly to diagnose slow builds), also generically adds a --profile flag to all evidence * commands which profiles the duration of the command's execution

Checklist

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: a2e428e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@evidence-dev/sdk Patch
@evidence-dev/universal-sql Patch
my-evidence-project Patch
@evidence-dev/evidence Patch
@evidence-dev/component-utilities Patch
@evidence-dev/core-components Patch
@evidence-dev/tailwind Patch
@evidence-dev/components Patch
evidence-test-environment Patch
@evidence-dev/plugin-connector Patch
e2e-spa Patch
e2e-themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:57pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 7:57pm

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit a2e428e
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/671169799919ca0007bc2edc
😎 Deploy Preview https://deploy-preview-2654--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit a2e428e
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/671169794dd34400096434f1
😎 Deploy Preview https://deploy-preview-2654--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit a2e428e
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/67116979199ac400085f0809
😎 Deploy Preview https://deploy-preview-2654--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@csjh
Copy link
Contributor Author

csjh commented Oct 16, 2024

@ItsMeBrianD any thoughts on the log.measure usage? I'm not sure if I'm a massive fan of the

let done;
if (isDebug()) { ... }

pattern

Could keep track of active labels internally and add a log.measureEnd ala console.timeEnd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants