Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix state test format benchmarking #1043

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

rodiazet
Copy link
Collaborator

@rodiazet rodiazet commented Oct 7, 2024

  • Add minimal changes to benchmark bls state tests.
  • Additional work required to make all test passing:
    • Pass proper pre_state to state::Host creation in bench_execute
    • Pass Transaction to bench_execute
    • Pass BlockInfo to bench_execute
    • Probably many more.

@rodiazet rodiazet force-pushed the bench-fix branch 3 times, most recently from 119841f to 0f7876d Compare October 9, 2024 09:31
@rodiazet rodiazet changed the title Bench fix test: Fix state test format benchmarking Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.17%. Comparing base (8e4a055) to head (ca95f71).

Files with missing lines Patch % Lines
test/bench/bench.cpp 0.00% 4 Missing ⚠️
test/bench/helpers.hpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
- Coverage   94.21%   94.17%   -0.04%     
==========================================
  Files         153      153              
  Lines       15934    15940       +6     
==========================================
  Hits        15012    15012              
- Misses        922      928       +6     
Flag Coverage Δ
eof_execution_spec_tests 17.53% <0.00%> (-0.01%) ⬇️
ethereum_tests 27.33% <0.00%> (-0.02%) ⬇️
ethereum_tests_silkpre 19.15% <0.00%> (-0.01%) ⬇️
execution_spec_tests 20.44% <0.00%> (-0.01%) ⬇️
unittests 88.97% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/bench/bench.cpp 0.00% <0.00%> (ø)
test/bench/helpers.hpp 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant