Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page #195773 #196969

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nabeelmohamed
Copy link

@nabeelmohamed nabeelmohamed commented Oct 19, 2024

Title: Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page

Description:
This PR fixes a typo on the "Dashboards" page for APM-service. The typo "dashaboard" has been corrected to "dashboard" to ensure proper functionality and readability.

Issue: #195773

Changes Made:

  • Corrected the typo in the text "To get started, add your dashaboard" to "To get started, add your dashboard."

Testing:

  • Verified the change on the Dashboards page for APM-service.
  • Ensured no other instances of the typo exist in the codebase.

Release note:
Fixes a typo on the "Dashboards" page for APM-service, changing 'dashaboard' to 'dashboard'.

Additional Notes:
No additional notes.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@nabeelmohamed nabeelmohamed requested a review from a team as a code owner October 19, 2024 04:42
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 19, 2024
Copy link

cla-checker-service bot commented Oct 19, 2024

💚 CLA has been signed

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@nabeelmohamed
Copy link
Author

hey need a help.after creating this PR i signed the contributor agreement. but in the checks its still unsuccessful. what to do . Also
prbot:release note labels — All PRs require a release_note:* label what should i do to to make this check successful. Somebody help

@nabeelmohamed nabeelmohamed changed the title Fix typo: change 'dashaboard' to 'dashboard' on APM-service Dashboard… mentioned in issue #195773 Fixes. the change 'dashaboard' to 'dashboard' on APM-service Dashboard… mentioned in issue #195773 Oct 19, 2024
@nabeelmohamed nabeelmohamed changed the title Fixes. the change 'dashaboard' to 'dashboard' on APM-service Dashboard… mentioned in issue #195773 Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page #195773 Oct 19, 2024
@nabeelmohamed
Copy link
Author

@smith brother i have updated the typo error but its failing some label checks . help me resolve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:project-deploy-observability Create an Observability project 💝community Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants