Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure_metrics] Enable subobjects: false on azure.resource.tags.* #11345

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Oct 7, 2024

Proposed commit message

Update azure.resource.tags mapping setting subobjects: true.

On Azure, users can set tag names with dots. When a tag name contains a dot, Elasticsearch expands the dots in the name into an object value, creating a conflict with the expected mapping.

This change allow users to index documents like this:

POST metrics-azure.monitor-pr11345/_doc
{
  "@timestamp": "2024-10-07T12:29:24+02:00",
  "azure": {
    "resource": {
      "id": "795166f8-3743-48dc-9d2e-3807f0375679",
      "tags": {
        "a": 1,
        "tag.with.dots": "value"
      }
    }
  }
}

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

@zmoog zmoog self-assigned this Oct 7, 2024
@zmoog zmoog added bugfix Pull request that fixes a bug issue Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Integration:azure_metrics Azure Resource Metrics labels Oct 7, 2024
@elasticmachine
Copy link

elasticmachine commented Oct 7, 2024

💔 Build Failed

Failed CI Steps

History

cc @zmoog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:azure_metrics Azure Resource Metrics Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[azure_metrics]: integration fails ingest metrics when resource tags contain dots in the name
2 participants