Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower retry count and improve error message of uninstall notifications #5756

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

michel-laterman
Copy link
Contributor

What does this PR do?

Lower the retry count and fix progress error messages for the unreleased uninstall notification features.

Why is it important?

With the current retry count the agent may be stuck for a few minutes while uninstalling

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@michel-laterman michel-laterman added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify labels Oct 10, 2024
@michel-laterman michel-laterman requested a review from a team as a code owner October 10, 2024 16:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@cmacknz
Copy link
Member

cmacknz commented Oct 10, 2024

We need to permanently log (i.e. not just as a transient message) why we are contact Fleet Server, not just that we are doing it, so that users can understand why they are waiting.

We should also consider having a configuration option to bypass this notification. There is a near trivial bypass for those with patience regardless, which is turning of the local network connection.

Currently we are most likely just annoying users whose Fleet might unreachable for known reasons. Anyone who wants to bypass the audit trail of the uninstall notification can just disable the network already.

@michel-laterman
Copy link
Contributor Author

I've created an issue to track skipping the notification entirely: #5757.

@michel-laterman
Copy link
Contributor Author

buildkite test this

1 similar comment
@jlind23
Copy link
Contributor

jlind23 commented Oct 11, 2024

buildkite test this

@michel-laterman michel-laterman merged commit 0a96561 into elastic:main Oct 11, 2024
14 checks passed
@michel-laterman michel-laterman deleted the fix-5752 branch October 11, 2024 18:43
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
michel-laterman added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify bug Something isn't working skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elastic-agent installed as Fleet server remains stuck in uninstalling with retry errors for over 4-5 minutes.
5 participants