-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower retry count and improve error message of uninstall notifications #5756
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
We need to permanently log (i.e. not just as a transient message) why we are contact Fleet Server, not just that we are doing it, so that users can understand why they are waiting. We should also consider having a configuration option to bypass this notification. There is a near trivial bypass for those with patience regardless, which is turning of the local network connection. Currently we are most likely just annoying users whose Fleet might unreachable for known reasons. Anyone who wants to bypass the audit trail of the uninstall notification can just disable the network already. |
I've created an issue to track skipping the notification entirely: #5757. |
buildkite test this |
1 similar comment
buildkite test this |
Quality Gate passedIssues Measures |
#5756) (#5766) (cherry picked from commit 0a96561) Co-authored-by: Michel Laterman <[email protected]>
What does this PR do?
Lower the retry count and fix progress error messages for the unreleased uninstall notification features.
Why is it important?
With the current retry count the agent may be stuck for a few minutes while uninstalling
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragments
using the changelog toolI have added an integration test or an E2E testRelated issues