Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gh artifacts upload with the latest action version #2605

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Oct 14, 2024

Summary of your changes

It seems that after a version update of upload-artifact something is wrong when we give a folder as a path to upload.

In our CI, we upload the produced Docker images as artifacts, which are later downloaded and used for kspm testing.

I didn't investigate the action code to find out why, but as a workaround, I changed the upload path from folder to wildcard pattern, and it works.

        path: |
          ${{ inputs.docker-images-folder }}/*.tar

Screenshot/Data

https://github.com/elastic/cloudbeat/actions/runs/11340902754?pr=2605

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Copy link

github-actions bot commented Oct 14, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 216
⬜ Skipped 33

@moukoublen moukoublen force-pushed the fix_gh_artifacts_upload branch 7 times, most recently from 33bfd20 to 3141051 Compare October 15, 2024 07:26
@moukoublen moukoublen marked this pull request as ready for review October 15, 2024 07:32
@moukoublen moukoublen requested a review from a team as a code owner October 15, 2024 07:32
Copy link
Collaborator

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why backport to 8.15?

@moukoublen
Copy link
Member Author

@oren-zohar because currently the 8.15 ci breaks because of that

@moukoublen moukoublen force-pushed the fix_gh_artifacts_upload branch 2 times, most recently from b82ce34 to b768b00 Compare October 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants