Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying Poetry projects #1916

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

oren-zohar
Copy link
Collaborator

@oren-zohar oren-zohar commented Feb 11, 2024

Summary of your changes

  • Unifying Poetry projects
  • Removing hermit Python dependency

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Copy link

mergify bot commented Feb 11, 2024

This pull request does not have a backport label. Could you fix it @oren-zohar? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

github-actions bot commented Feb 11, 2024

❌ No tests were run ❌

@oren-zohar oren-zohar marked this pull request as ready for review February 14, 2024 14:58
@oren-zohar oren-zohar requested a review from a team as a code owner February 14, 2024 14:58
pip3 install poetry
cd security-policies
poetry install
pipx install poetry
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use pipx in this workflow and pip3 in other workflows?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For installing Python-based CLI tools (like poetry, black, flake8, etc.), it's recommended to use use pipx. For installing Python packages to the environment, such as libraries used in your code (like numpy, pandas, requests, etc.), use pip/pip3`. I will update the other workflows

env:
STACK_VERSION: ${{ env.ELK_VERSION }}
DEPLOYMENT_NAME: ${{env.GCP_DEPLOYMENT_NAME}}
run: |
poetry install
poetry run python src/install_cspm_gcp_integration.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my mistake; the path is incorrect. It should now be tests/integrations_setup/install_cspm_gcp_integration.py.

Copy link
Collaborator

@gurevichdmitry gurevichdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oren-zohar Great work! Why didn't you remove pyproject.toml in the tests and security-policies directories as well? The tests Dockerfile needs fixing; otherwise, this will not work for K8s CI testing.

Copy link

mergify bot commented Apr 15, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b combine-poetry upstream/combine-poetry
git merge upstream/main
git push upstream combine-poetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants