iframe width and tabs #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egoist
requested changes
Jun 21, 2019
src/store/index.js
Outdated
| @@ -68,7 +69,7 @@ const store = new Vuex.Store({ | |||
| state: { | |||
| ...emptyPans(), | |||
| logs: [], | |||
| visiblePans: ['html', 'js', 'output'], | |||
| visiblePans: visiblePans || ['html', 'js', 'output'], | |||
There was a problem hiding this comment.
we can use $store.dispatch('showPans', []) and $route.query instead
There was a problem hiding this comment.
const params2 = router.match(window.location).query returns nothing. Otherwise $route object isn't accessible outside vue.
|
Please merge and reward |
|
@egoist ? |
|
@egoist please merge, its been half a year |
|
@egoist wouldn't mind just the bounty, pr review whenever you feel like it. Its been half a year. |
|
@egoist ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #63
I don't know if the doc folder actually does anything, but I added docs there.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor