Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Add is_valid_url? function #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[PR] Add is_valid_url? function #68

wants to merge 3 commits into from

Conversation

LuchoTurtle
Copy link
Member

closes #64

This is a quick merge. Found this useful for small Elixir projects, thanks @ndrean 👌

@LuchoTurtle LuchoTurtle added enhancement New feature or request awaiting-review An issue or pull request that needs to be reviewed labels Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #68 (f329075) into main (335303d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           50        52    +2     
=========================================
+ Hits            50        52    +2     
Files Coverage Δ
lib/useful.ex 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@nelsonic
Copy link
Member

Agree that checking the validity of a URL is useful. ✅
Just have a quick question in the issue: #64 (comment)

If you need this function immeditately, please see: https://hexdocs.pm/link/Link.html#valid?/1
https://github.com/dwyl/link/blob/ca72089c0a56a0e1a96360ccba424b49b8165e3b/lib/link.ex#L143-L161 💭

@LuchoTurtle LuchoTurtle mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_valid_url?
2 participants