Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add setOptions on f-data-validation-builder #3773

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 16, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 16, 2024

View Deployment

#11379999521

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

github-actions bot commented Oct 16, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 9 seconds
commit  cb14bf5
info  For more information, see full report

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.96%. Comparing base (4ecd764) to head (cb14bf5).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...acade/src/apis/sheets/f-data-validation-builder.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3773      +/-   ##
==========================================
- Coverage   30.96%   30.96%   -0.01%     
==========================================
  Files        2286     2286              
  Lines      118588   118591       +3     
  Branches    26128    26128              
==========================================
  Hits        36726    36726              
- Misses      81862    81865       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 4008c86 into dev Oct 17, 2024
9 checks passed
@weird94 weird94 deleted the feat/dv-facade-1016 branch October 17, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants