Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: font render bounds #3754

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix: font render bounds #3754

merged 3 commits into from
Oct 17, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Oct 15, 2024

close https://github.com/dream-num/univer-pro/issues/2809

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 15, 2024

View Deployment

#11378178226

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

Playwright test results

passed  16 passed
flaky  1 flaky

Details

stats  17 tests across 8 suites
duration  4 minutes, 32 seconds
commit  45471fe
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 30.96%. Comparing base (e1aeec0) to head (45471fe).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ne-render/src/components/sheets/extensions/font.ts 0.00% 16 Missing ⚠️
...gine-render/src/components/docs/extensions/line.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3754   +/-   ##
=======================================
  Coverage   30.96%   30.96%           
=======================================
  Files        2286     2286           
  Lines      118558   118588   +30     
  Branches    26113    26128   +15     
=======================================
+ Hits        36714    36726   +12     
- Misses      81844    81862   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 16, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 16, 2024
there should be a text "A1"
@lumixraku lumixraku merged commit 4ecd764 into dev Oct 17, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/font-cell branch October 17, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants