Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(facade): separated to plugins to be composable #3730

Draft
wants to merge 29 commits into
base: dev
Choose a base branch
from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 12, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev changed the title refactor(facade): refactor facade refactor(facade): separate facade to plugins to make it composable Oct 14, 2024
@wzhudev wzhudev changed the title refactor(facade): separate facade to plugins to make it composable refactor(facade): separated to plugins to make it composable Oct 14, 2024
@wzhudev wzhudev changed the title refactor(facade): separated to plugins to make it composable refactor(facade): separated to plugins to be composable Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Playwright test results

failed  1 failed
passed  16 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 33 seconds
commit  f0560ea
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

@wzhudev
Copy link
Member Author

wzhudev commented Oct 14, 2024

@jikkai We need config sideEffect.

@wzhudev wzhudev force-pushed the refactor/facade-extend branch 2 times, most recently from 2da8bd8 to 39ce223 Compare October 14, 2024 13:26
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0.12937% with 772 lines in your changes missing coverage. Please review.

Project coverage is 29.94%. Comparing base (d29da2f) to head (f0560ea).

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-workbook.ts 0.00% 115 Missing ⚠️
...es/sheets-data-validation/src/facade/f-workbook.ts 0.00% 62 Missing ⚠️
packages/sheets-ui/src/facade/f-univer.ts 0.00% 45 Missing ⚠️
packages/sheets-ui/src/facade/f-range.ts 0.00% 39 Missing ⚠️
packages/core/src/facade/f-hooks.ts 0.00% 34 Missing ⚠️
...ckages/sheets-thread-comment/src/facade/f-range.ts 0.00% 32 Missing ⚠️
...ges/sheets-thread-comment/src/facade/f-workbook.ts 0.00% 32 Missing ⚠️
packages/core/src/facade/f-univer.ts 0.00% 28 Missing ⚠️
packages/sheets-thread-comment-ui/src/plugin.ts 0.00% 27 Missing ⚠️
...kages/sheets-data-validation/src/facade/f-range.ts 0.00% 21 Missing ⚠️
... and 47 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3730      +/-   ##
==========================================
- Coverage   30.96%   29.94%   -1.02%     
==========================================
  Files        2286     2309      +23     
  Lines      118601   118644      +43     
  Branches    26130    26132       +2     
==========================================
- Hits        36726    35533    -1193     
- Misses      81875    83111    +1236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants