Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add some statistical formulas #3684

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Oct 10, 2024

close https://github.com/dream-num/univer-pro/issues/2633
close https://github.com/dream-num/univer-pro/issues/2841

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 10, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 9 seconds
commit  32fa694
info  For more information, see full report

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 94.06960% with 167 lines in your changes missing coverage. Please review.

Project coverage is 33.21%. Comparing base (b0c5f13) to head (32fa694).

Files with missing lines Patch % Lines
packages/engine-formula/src/basics/math.ts 79.06% 45 Missing ⚠️
...ngine-formula/src/engine/ast-node/function-node.ts 0.00% 9 Missing ⚠️
packages/engine-formula/src/basics/statistical.ts 94.70% 8 Missing ⚠️
...rmula/src/functions/statistical/beta-dist/index.ts 58.33% 5 Missing ⚠️
...-formula/src/functions/statistical/t-test/index.ts 96.24% 5 Missing ⚠️
...mula/src/functions/compatibility/betadist/index.ts 60.00% 4 Missing ⚠️
...ormula/src/functions/statistical/beta-inv/index.ts 60.00% 4 Missing ⚠️
...formula/src/functions/compatibility/tdist/index.ts 93.02% 3 Missing ⚠️
...rc/functions/statistical/binom-dist-range/index.ts 62.50% 3 Missing ⚠️
...mula/src/functions/statistical/binom-dist/index.ts 62.50% 3 Missing ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3684      +/-   ##
==========================================
+ Coverage   31.83%   33.21%   +1.38%     
==========================================
  Files        2309     2359      +50     
  Lines      119802   122507    +2705     
  Branches    26497    27310     +813     
==========================================
+ Hits        38136    40691    +2555     
- Misses      81666    81816     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wpxp123456 wpxp123456 force-pushed the feat/add-statistical-function branch 3 times, most recently from d2b24d5 to 863ccb1 Compare October 15, 2024 06:42
@oumomomo
Copy link

oumomomo commented Oct 18, 2024

GAMMA函数

1、单元格内输入=GAMMA(174),计算结果未报错
image

2、单元格内输入=GAMMA(B14),B14=1月2日 计算结果未报错
image

@univer-bot
Copy link

univer-bot bot commented Oct 18, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

GAMMA function

  1. Enter =GAMMA(174) in the cell, and no error will be reported in the calculation result.
    image

  2. Enter =GAMMA(B14) in the cell, B14=January 2. The calculation result does not report an error.
    image

@oumomomo
Copy link

GAMMA.INV函数

单元格内输入=GAMMA.INV(0.1,10000000,1000),计算结果不一致
image

@univer-bot
Copy link

univer-bot bot commented Oct 18, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

GAMMA.INV function

Enter =GAMMA.INV(0.1,10000000,1000) in the cell, but the calculation results are inconsistent.
image

@oumomomo
Copy link

oumomomo commented Oct 18, 2024

GAMMALN函数

单元格内输入=GAMMALN/GAMMALN.PRECISE(2),计算结果不对
image

@univer-bot
Copy link

univer-bot bot commented Oct 18, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

GAMMALN function

Enter =GAMMALN/GAMMALN.PRECISE(2) into the cell, and the calculation result is incorrect.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants