Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix for TextDecorations not updating after modifying Label text #25339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

Root Cause of the issue

When setting normal text dynamically, the previously set attributed text decoration remains. When trying to set new attributed text decoration, both the previously set and newly set attributed text decoration appear in the label.

Description of Change

When updating normal text, make sure that AttributedText is set to null to remove any decorations from previous updates. This ensures that the newly set attributed text works correctly.

Issues Fixed

Fixes #16967

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
TextDecorationIssue.mp4
TextDecorationfixed.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 17, 2024
Copy link
Contributor

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman changed the title Fixed 16967 [iOS] Fix for the issue with existing TextDecorations applied to a Label are not removed when a new TextDecoration value is set after the Label's Text has been modified. Oct 17, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman changed the title [iOS] Fix for the issue with existing TextDecorations applied to a Label are not removed when a new TextDecoration value is set after the Label's Text has been modified. [iOS] Fix for TextDecorations not updating after modifying Label text. Oct 17, 2024
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman changed the title [iOS] Fix for TextDecorations not updating after modifying Label text. [iOS] Fix for TextDecorations not updating after modifying Label text Oct 17, 2024
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review October 18, 2024 11:18
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner October 18, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants