simplify the code for diagnostics severity adjustment #17896
Conversation
|
|
Can somebody add the "no release notes" label? |
psfinaki
added
the
NO_RELEASE_NOTES
|
There you go, Martin :) Thanks for splitting the refactoring into a separate PR, that's always helpful. |
|
|
||
| // We use the first line of the file as a fallbackRange for reporting unexpected errors. | ||
| // Not ideal, but it's hard to see what else to do. | ||
| let fallbackRange = rangeN mainInputFileName 1 | ||
| let diagnostic = FSharpDiagnostic.CreateFromExceptionAndAdjustEof (diagnostic, severity, fallbackRange, fileInfo, suggestNames, flatErrors, symbolEnv) | ||
| let diagnostic = FSharpDiagnostic.CreateFromExceptionAndAdjustEof (diagnostic, sev, fallbackRange, fileInfo, suggestNames, flatErrors, symbolEnv) |
There was a problem hiding this comment.
It was originally severity, we have always had problems with abbreviations in this codebase, in general avoid them, especially if they were originally unabbreviated.
There was a problem hiding this comment.
I didn't want to shadow the original severity. I'll make it adjustedSeverity.
| List.contains n options.WarnOn && not (List.contains n options.WarnOff) | ||
|
|
||
| | FSharpDiagnosticSeverity.Hidden -> false | ||
| member x.AdjustedSeverity(options, severity) = |
There was a problem hiding this comment.
Should it be AdjustSeverity?
There was a problem hiding this comment.
member x.AdjustSeverity(,) sounds like changing the state of object x, while it is just a pure function.
(Honestly, it shouldn't be a member at all. The whole type extensions doesn't look right. I might tackle that separately. )
Unless there are big objections, I will leave the name for now.
Description
This PR simplifies the code for adjusting diagnostics severity, without change to the functionality.
It will be needed for "scoped nowarn", where the adjustment logic becomes even more complex, but makes sense also in itself.