Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pepys config file #202

Merged
merged 27 commits into from
Mar 13, 2020
Merged

Feature/pepys config file #202

merged 27 commits into from
Mar 13, 2020

Conversation

BarisSari
Copy link
Contributor

@BarisSari BarisSari commented Mar 12, 2020 •
edited
Loading

Fixes #195.
Fixes #119.
Fixes #203.
Fixes #189.

Note: There was an error on moving files when we pass descending=False to File Processor. This PR also fixes it and therefore, adds patches to some old tests.

@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #202 into develop will increase coverage by 0.04%.
The diff coverage is 98%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #202      +/-   ##
===========================================
+ Coverage    96.39%   96.43%   +0.04%     
===========================================
  Files           77       83       +6     
  Lines         6125     6319     +194     
===========================================
+ Hits          5904     6094     +190     
- Misses         221      225       +4
Impacted Files Coverage Δ
tests/config_file_tests/parsers/importer.py 100% <ø> (ø)
config.py 100% <100%> (ø)
tests/test_load_rep_comment.py 98.33% <100%> (+0.08%) ⬆️
pepys_import/file/file_processor.py 97.57% <100%> (-0.08%) ⬇️
tests/test_datafile_reference.py 96.42% <100%> (+0.27%) ⬆️
tests/test_load_rep.py 97.14% <100%> (+0.17%) ⬆️
tests/test_load_nmea.py 97.14% <100%> (+0.17%) ⬆️
pepys_import/core/store/common_db.py 99.06% <100%> (+0.09%) ⬆️
pepys_import/utils/config_utils.py 100% <100%> (ø)
tests/config_file_tests/enhanced_tests/enhanced.py 83.33% <83.33%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45fd82...aab76b4. Read the comment docs.

@robintw robintw mentioned this pull request Mar 12, 2020
Closed
@BarisSari BarisSari changed the title [WIP] Feature/pepys config file Feature/pepys config file Mar 13, 2020
@BarisSari BarisSari marked this pull request as ready for review March 13, 2020 15:20
@BarisSari BarisSari requested a review from IanMayo March 13, 2020 15:21
IanMayo
IanMayo approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@IanMayo IanMayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good piece of work, thanks @BarisSari

@IanMayo IanMayo merged commit 8c3b3e8 into develop Mar 13, 2020
@IanMayo IanMayo deleted the feature/pepys_config_file branch March 13, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMayo IanMayo IanMayo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BarisSari @IanMayo