-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add back support for To|FromEnvironmentFieldPath type in environment patches #125
Merged
phisco
merged 1 commit into
crossplane-contrib:main
from
truongnht:support-ToEnvironmentFieldPath-in-spec.environment.patches
May 29, 2024
Merged
fix: Add back support for To|FromEnvironmentFieldPath type in environment patches #125
phisco
merged 1 commit into
crossplane-contrib:main
from
truongnht:support-ToEnvironmentFieldPath-in-spec.environment.patches
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did run the tests with the result
|
can you also update
|
truongnht
force-pushed
the
support-ToEnvironmentFieldPath-in-spec.environment.patches
branch
from
May 29, 2024 13:14
de3467a
to
4846fba
Compare
phisco
changed the title
Add support for To|FromEnvironmentFieldPath type in environment patches
fix: Add back support for To|FromEnvironmentFieldPath type in environment patches
May 29, 2024
Resolves crossplane-contrib#123 Signed-off-by: Truong Nguyen <[email protected]>
truongnht
force-pushed
the
support-ToEnvironmentFieldPath-in-spec.environment.patches
branch
from
May 29, 2024 13:18
4846fba
to
cf8cbaa
Compare
phisco
approved these changes
May 29, 2024
truongnht
deleted the
support-ToEnvironmentFieldPath-in-spec.environment.patches
branch
May 29, 2024 13:27
This is great. That would allow us to upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123