test: added suppport for version specific actions e2e test #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
github-actions
bot
added
C:Testing
bermuell
force-pushed
the
bernd/2198-e2e-test
branch
2 times, most recently
from
4e7773b
to
9cae0fa
Compare
bermuell
force-pushed
the
bernd/2198-e2e-test
branch
from
9cae0fa
to
8388dd4
Compare
bermuell
force-pushed
the
bernd/2198-e2e-test
branch
from
8388dd4
to
c59766e
Compare
stana-miric
reviewed
Oct 18, 2024
| // wait for inclusion in a block -> '--broadcast-mode block' is deprecated | ||
| tr.waitBlocks(ChainID("provi"), 2, 30*time.Second) | ||
| //tr.waitBlocks(ChainID("provi"), 2, 30*time.Second) |
stana-miric
reviewed
Oct 18, 2024
| // wait for the transaction | ||
| start := time.Now() | ||
| for { | ||
| res, err := tr.target.QueryTransaction(chain, response.TxHash) |
There was a problem hiding this comment.
maybe we can add some sleep of one second(or commit time), just to avoid querying too often
stana-miric
reviewed
Oct 18, 2024
|
|
||
| func (tr Commands) getValidatorNode(chain ChainID, validator ValidatorID) string { | ||
| // for CometMock, validatorNodes are all the same address as the query node (which is CometMocks address) | ||
| // TODO: @bermuell Fix this !!! |
There was a problem hiding this comment.
is this comment still valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2198
Refactoring of tests to support execution of tests against target versions (provider, consumer) where execution
of action differs.
action handlerand commands for v5tested with compatibility tests on versions v5.2.0 (consumer/provider) v6.1.0 (consumer/provider)
compatibility of consumer v5.x with provider version v6.2.x is broken (issue #2359)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...